fix(helm): always create default metrics source if traces are enabled #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pmalek-sumo
force-pushed
the
always-create-metrics-source-if-traces-are-enabled
branch
from
9af6eb6 to
f098cd2
Compare
| */}} | ||
| {{- range $key, $source := $sources }} | ||
| {{- if eq $key "default"}} | ||
| {{ include "terraform.sources.data" (dict "Endpoint" (include "terraform.sources.config-map-variable" (dict "Type" $type "Context" $ctx "Name" $key)) "Name" (include "terraform.sources.name" (dict "Name" $key "Type" $type))) }} |
There was a problem hiding this comment.
I think it would be more readable and less changes if we always create this endpoint (regardless of metrics and tracing configuration). If we have to add it for traces we can add it for logs as well and we just won't use it
pmalek-sumo
force-pushed
the
always-create-metrics-source-if-traces-are-enabled
branch
from
f098cd2 to
a76f72d
Compare
pmalek-sumo
force-pushed
the
always-create-metrics-source-if-traces-are-enabled
branch
from
a76f72d to
da38548
Compare
pmalek-sumo
deleted the
always-create-metrics-source-if-traces-are-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After introducing: #1647 we got into a bit of a situation for users who enable traces but don't enable metrics.
The problem's root cause is that traces pipeline now requires default metrics endpoint to be available
sumologic-kubernetes-collection/deploy/helm/sumologic/values.yaml
Line 3498 in 9bf45ca
This PR addresses that by always creating default metrics endpoint when traces are enabled in the chart.
There's a separate issue that tries to address the meaning of different configuration options in
values.yamlthat's tracked in #2183.